Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Oct 21, 2025

Summary by Sourcery

Bug Fixes:

  • Correct null check error message to reference session properties instead of system properties in ConnectorServices

@cla-bot cla-bot bot added the cla-signed label Oct 21, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Corrected a typo in the null-check error message for session properties in ConnectorServices.

File-Level Changes

Change Details Files
Fixed incorrect error message in requireNonNull for sessionProperties
  • Changed message from “null system properties set” to “null session properties set”
core/trino-main/src/main/java/io/trino/connector/ConnectorServices.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@electrum electrum requested a review from Copilot October 21, 2025 22:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixed an error message in ConnectorServices where the null check for session properties incorrectly referenced "system properties" instead of "session properties".


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Oct 22, 2025
@findepi findepi merged commit 44a0192 into trinodb:master Oct 22, 2025
98 checks passed
@findepi findepi deleted the findepi/fix-typo-in-null-check-message-cca6b8 branch October 22, 2025 07:37
@github-actions github-actions bot added this to the 478 milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants